Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handlebars import for media provider, pw env file #311

Merged
merged 1 commit into from
Nov 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS=1
2 changes: 0 additions & 2 deletions .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ jobs:
playwright:
timeout-minutes: 60
runs-on: ubuntu-latest
env:
PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS: 1
steps:
- name: Remove all fonts
run: rm -rf /usr/share/fonts
Expand Down
3 changes: 0 additions & 3 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,5 @@
"source.fixAll.eslint": true,
},
"eslint.format.enable": true,
"playwright.env": {
"PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS": 1
},
"javascript.preferences.importModuleSpecifierEnding": "js",
}
5 changes: 0 additions & 5 deletions ext/js/display/display-audio.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ import {PopupMenu} from '../dom/popup-menu.js';
import {AudioSystem} from '../media/audio-system.js';
import {yomichan} from '../yomichan.js';

/* global
* AudioSystem
* PopupMenu
*/

export class DisplayAudio {
constructor(display) {
this._display = display;
Expand Down
11 changes: 0 additions & 11 deletions ext/js/display/popup-main.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,6 @@ import {DisplayProfileSelection} from './display-profile-selection.js';
import {DisplayResizer} from './display-resizer.js';
import {Display} from './display.js';

/* global
* Display
* DisplayAnki
* DisplayAudio
* DisplayProfileSelection
* DisplayResizer
* DocumentFocusController
* HotkeyHandler
* JapaneseUtil
*/

(async () => {
try {
const documentFocusController = new DocumentFocusController();
Expand Down
4 changes: 0 additions & 4 deletions ext/js/pages/settings/dictionary-controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ import {EventListenerCollection, log} from '../../core.js';
import {DictionaryWorker} from '../../language/dictionary-worker.js';
import {yomichan} from '../../yomichan.js';

/* global
* DictionaryWorker
*/

class DictionaryEntry {
constructor(dictionaryController, fragment, index, dictionaryInfo) {
this._dictionaryController = dictionaryController;
Expand Down
6 changes: 0 additions & 6 deletions ext/js/pages/settings/popup-preview-frame-main.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,6 @@ import {HotkeyHandler} from '../../input/hotkey-handler.js';
import {yomichan} from '../../yomichan.js';
import {PopupPreviewFrame} from './popup-preview-frame.js';

/* global
* HotkeyHandler
* PopupFactory
* PopupPreviewFrame
*/

(async () => {
try {
await yomichan.prepare();
Expand Down
4 changes: 1 addition & 3 deletions ext/js/templates/sandbox/template-renderer-media-provider.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

/* global
* Handlebars
*/
import {Handlebars} from '../../../lib/handlebars.js';

export class TemplateRendererMediaProvider {
constructor() {
Expand Down
19 changes: 19 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
"css": "^3.0.0",
"dexie": "^3.2.4",
"dexie-export-import": "^4.0.7",
"dotenv": "^16.3.1",
"esbuild": "^0.19.5",
"eslint": "^8.52.0",
"eslint-plugin-header": "^3.1.1",
Expand Down
2 changes: 1 addition & 1 deletion playwright.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import {defineConfig, devices} from '@playwright/test';
* Read environment variables from file.
* https://github.com/motdotla/dotenv
*/
// require('dotenv').config();
import 'dotenv/config';

/**
* @see https://playwright.dev/docs/test-configuration
Expand Down
Loading