Fix Chrome death, by creating both cross-frame ports in the background #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View Playwright Report (note: open the "playwright-report" artifact) |
on Chrome (currently 117), the port created in the content script with runtime.connect does not properly receive an onDisconnect event when the service worker sleeps. the port created in the background with tabs.connect does receive the event, so create both ports with tabs.connect. fixes yomidevs#241.
praschke
force-pushed
the
chrome-death-fix
branch
from
0bf7c69 to
6769ff5
Compare
djahandarie
reviewed
Oct 1, 2023
djahandarie
added
kind/bug
djahandarie
changed the title
djahandarie
reviewed
Oct 1, 2023
djahandarie
previously approved these changes
Oct 1, 2023
it was only used in the cross-frame api. additionally, this comment on triggerExtensionUnloaded is incorrect.
not sure if API messages should be sent in prepare(), but we should probably wait for the ready signal before doing so
auto-merge was automatically disabled
October 1, 2023 08:51
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on Chrome (currently 117), the port created in the content script with runtime.connect does not properly receive an onDisconnect event when the service worker sleeps. the port created in the background with tabs.connect does receive the event, so create both ports with tabs.connect.
fixes #241.