Remove hardcoded version from manifest #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themoeway-bot
previously approved these changes
Sep 23, 2023
djahandarie
force-pushed
the
remove-version
branch
from
2d8f6be to
c27dfcc
Compare
themoeway-bot
previously approved these changes
Sep 23, 2023
djahandarie
force-pushed
the
remove-version
branch
from
c27dfcc to
38420e3
Compare
themoeway-bot
previously approved these changes
Sep 23, 2023
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
djahandarie
force-pushed
the
remove-version
branch
from
38420e3 to
d349ec9
Compare
themoeway-bot
previously approved these changes
Sep 23, 2023
djahandarie
force-pushed
the
remove-version
branch
from
d349ec9 to
2eebcde
Compare
themoeway-bot
previously approved these changes
Sep 23, 2023
* Dynamically set version as argument to build script * Set version using tag ref_name in CI * [Cleanup] gitignore ext/manifest.json as it's dynamically generated
djahandarie
force-pushed
the
remove-version
branch
from
2eebcde to
6f24ac4
Compare
themoeway-bot
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
To make it easier and less error-prone to do new releases. Now a commit will no longer be required, and simply making a new tag will suffice.