Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up getFrequencyOrder for other languages #1616

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Nov 26, 2024

Related #1611

This PR doesn't actually fix anything, but this should make it easy for people more knowledgeable in languages to help get this fixed.

Some dicts dont set a language tag so it will just test all words from every language in that case.

(The funky if (Object.hasOwn(moreCommonTerms, key)) is because of this js fun: https://eslint.org/docs/latest/rules/guard-for-in)

@Kuuuube Kuuuube added kind/meta The issue or PR is meta area/linguistics The issue or PR is related to linguistics labels Nov 26, 2024
@Kuuuube Kuuuube requested a review from a team as a code owner November 26, 2024 18:51
@jamesmaa jamesmaa added this pull request to the merge queue Dec 5, 2024
Merged via the queue into yomidevs:master with commit d841d6b Dec 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/linguistics The issue or PR is related to linguistics kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants