Make mobile styling for action popup more reliable #1595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/bug
This reverts commit 8e4f375.
…d ignoring mobile overrides
|
Will be superceded by #1525 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, sometimes the styling doesn't work even though Yomitan does detect the correct action popup to use (mini or full). Sometimes the current styling can also detect certain laptops with touchscreens as being mobile devices. But we cannot remove the
@media (hover: none)selector due to it breaking Firefox support.Tested on both Firefox and Kiwi but I can't replicate the issue anyways to know 100% if this fixes it, only that it doesn't break anything further. Testers would be appreciated.