Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove touchInputEnabled and pointerEventsEnabled #1585

Merged
merged 12 commits into from
Nov 25, 2024
Merged

Remove touchInputEnabled and pointerEventsEnabled #1585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7718914
Remove touchInputEnabled and pointerEventsEnabled
jamesmaa Nov 6, 2024
263e097
Revert small change
jamesmaa Nov 6, 2024
20a391e
Missed change
jamesmaa Nov 6, 2024
ecd6137
Forgot to save
jamesmaa Nov 6, 2024
0ac18d7
Restore _getPointerEventListeners
jamesmaa Nov 6, 2024
e39daf1
Remove unused code
jamesmaa Nov 6, 2024
ac98aa6
Add touchEnd and contextMenu
jamesmaa Nov 6, 2024
1ca9ff3
Refactor MouseEvent into PointerEvent
khaitruong922 Nov 11, 2024
fcb7335
typing
khaitruong922 Nov 11, 2024
795f9cd
Restore 'mousedown'
khaitruong922 Nov 11, 2024
83930a4
touch tap invalidation when touch move
khaitruong922 Nov 11, 2024
2e88bdd
remove return for void functions
khaitruong922 Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions ext/data/schemas/options-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,8 +453,6 @@
"required": [
"inputs",
"preventMiddleMouse",
"touchInputEnabled",
"pointerEventsEnabled",
"selectText",
"alphanumeric",
"autoHideResults",
Expand Down Expand Up @@ -676,14 +674,6 @@
}
}
},
"touchInputEnabled": {
"type": "boolean",
"default": true
},
"pointerEventsEnabled": {
"type": "boolean",
"default": false
},
"selectText": {
"type": "boolean",
"default": true
Expand Down
2 changes: 0 additions & 2 deletions ext/js/app/frontend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,8 +506,6 @@ export class Frontend {
normalizeCssZoom: scanningOptions.normalizeCssZoom,
selectText: scanningOptions.selectText,
delay: scanningOptions.delay,
touchInputEnabled: scanningOptions.touchInputEnabled,
pointerEventsEnabled: scanningOptions.pointerEventsEnabled,
scanLength: scanningOptions.length,
layoutAwareScan: scanningOptions.layoutAwareScan,
matchTypePrefix: scanningOptions.matchTypePrefix,
Expand Down
13 changes: 13 additions & 0 deletions ext/js/data/options-util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,6 +566,7 @@ export class OptionsUtil {
this._updateVersion52,
this._updateVersion53,
this._updateVersion54,
this._updateVersion55,
];
/* eslint-enable @typescript-eslint/unbound-method */
if (typeof targetVersion === 'number' && targetVersion < result.length) {
Expand Down Expand Up @@ -1521,6 +1522,18 @@ export class OptionsUtil {
}
}

/**
* - Remove scanning.touchInputEnabled
* - Remove scanning.pointerEventsEnabled
* @type {import('options-util').UpdateFunction}
*/
async _updateVersion55(options) {
for (const profile of options.profiles) {
delete profile.options.scanning.touchInputEnabled;
delete profile.options.scanning.pointerEventsEnabled;
}
}

/**
* @param {string} url
* @returns {Promise<chrome.tabs.Tab>}
Expand Down
4 changes: 0 additions & 4 deletions ext/js/display/display.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,8 +457,6 @@ export class Display extends EventDispatcher {
normalizeCssZoom: scanningOptions.normalizeCssZoom,
selectText: scanningOptions.selectText,
delay: scanningOptions.delay,
touchInputEnabled: scanningOptions.touchInputEnabled,
pointerEventsEnabled: scanningOptions.pointerEventsEnabled,
scanLength: scanningOptions.length,
layoutAwareScan: scanningOptions.layoutAwareScan,
preventMiddleMouse: scanningOptions.preventMiddleMouse.onSearchQuery,
Expand Down Expand Up @@ -2054,8 +2052,6 @@ export class Display extends EventDispatcher {
normalizeCssZoom: scanningOptions.normalizeCssZoom,
selectText: false,
delay: scanningOptions.delay,
touchInputEnabled: false,
pointerEventsEnabled: false,
scanLength: scanningOptions.length,
layoutAwareScan: scanningOptions.layoutAwareScan,
preventMiddleMouse: false,
Expand Down
Loading