Remove touchInputEnabled and pointerEventsEnabled #1576
Conversation
CodSpeed Performance ReportMerging #1576 will not alter performanceComparing Summary
|
ext/js/language/text-scanner.js
Outdated
| } else if (this._arePointerEventsSupported()) { | ||
| eventListenerInfos = this._getPointerEventListeners(capture); | ||
| } else { | ||
| eventListenerInfos = [...this._getMouseEventListeners(capture)]; | ||
| if (this._scanWithoutMousemove) { | ||
| eventListenerInfos.push(...this._getKeyboardEventListeners(capture)); | ||
| } | ||
| if (this._touchInputEnabled) { | ||
| eventListenerInfos.push(...this._getTouchEventListeners(capture)); | ||
| } |
There was a problem hiding this comment.
We still need to call these functions to register the event listeners for touch and pen. Only need to remove the if check for this._touchInputEnabled and this._pointerEventsEnabled since we are removing these options and having them true by default.
There was a problem hiding this comment.
We might only want one or the other. According to #466, only pointer events should be required. Though I've never seen any browser that doesn't support both equally.
There was a problem hiding this comment.
Maybe need to test if this breaks touch behavior on popup components.
There was a problem hiding this comment.
So is the ask here to restore
} else if (this._arePointerEventsSupported()) {
eventListenerInfos = this._getPointerEventListeners(capture);and keep this line?
Playwright test results
Details
Failed testschromium › visual.spec.js › visual |
jamesmaa
force-pushed
the
remove-scan-inputs
branch
from
278807d to
0ac18d7
Compare
|
Closing in favor of #1585 |
Fixes #466
I just followed instructions of removing the option and related code and very lightly tested functionality