Update dictionary will update alias if alias is the same as previous title #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaitruong922
force-pushed
the
update-dictionary-alias
branch
from
f471b23 to
b2f5440
Compare
jamesmaa
approved these changes
Nov 5, 2024
Kuuuube
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional change to #1553.
Since we are preserving the alias when updating dictionaries, for dictionaries which have new title for every new version, the alias does not match the title after updated. For example:
Therefore, we want to update the alias if it is the same as the title (not yet set by the user), and preserve the alias otherwise.