Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scanning without moving mouse from clicking #1538

Merged

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Oct 28, 2024

Fixes #1280.

Needs more testing and probably some cleanup. This should also allow removing the option for scanning with middle click in favor of the user adding a scanning input option containing middle click (or any mouse button they want).

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Oct 28, 2024
@Kuuuube Kuuuube marked this pull request as ready for review October 28, 2024 20:43
@Kuuuube Kuuuube requested a review from a team as a code owner October 28, 2024 20:43
@Kuuuube
Copy link
Member Author

Kuuuube commented Oct 28, 2024

Gave this some more testing and I don't see it breaking anything. Should be good to merge.

@Kuuuube Kuuuube added this pull request to the merge queue Oct 28, 2024
Merged via the queue into yomidevs:master with commit 7ed53c1 Oct 28, 2024
11 checks passed
@Kuuuube Kuuuube deleted the allow-scanning-while-stationary-with-clicks branch October 28, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search with Stationary cursor and Mouse 0?
2 participants