Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright Comment on Flaky Tests #1531

Merged
merged 4 commits into from
Oct 27, 2024

Conversation

MarvNC
Copy link
Member

@MarvNC MarvNC commented Oct 26, 2024

Resolves #1529
Previously it didn't check for flaky tests so issues could get by.

Haven't tested but I just copied the logic from the line above so it probably works.

@MarvNC MarvNC requested a review from a team as a code owner October 26, 2024 11:02
@MarvNC
Copy link
Member Author

MarvNC commented Oct 26, 2024

Not quite sure why this line caused an error in the log, but didn't cause the test as a whole to count as an error at the end and instead only registered "flaky".

await expect(page.locator('id=dictionaries')).toHaveText('Dictionaries (1 installed, 1 enabled)', {timeout: 5 * 60 * 1000});

@MarvNC
Copy link
Member Author

MarvNC commented Oct 26, 2024

Seems the .github/workflows/playwright_comment.yml that's run in this PR isn't the latest one because the workflow isn't directly called, so it didn't comment.

@jamesmaa jamesmaa added this pull request to the merge queue Oct 27, 2024
Merged via the queue into yomidevs:master with commit 086e043 Oct 27, 2024
11 checks passed
Copy link

github-actions bot commented Oct 27, 2024

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@MarvNC MarvNC deleted the fix-playwright-comment branch October 27, 2024 17:57
@MarvNC MarvNC restored the fix-playwright-comment branch October 27, 2024 17:58
@MarvNC MarvNC deleted the fix-playwright-comment branch October 27, 2024 17:58
@MarvNC MarvNC added kind/meta The issue or PR is meta area/ci The issue or PR is related to continuous integration and/or continuous delivery labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci The issue or PR is related to continuous integration and/or continuous delivery kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Playwright Action Not Erroring
2 participants