Bump Dev Dependencies #1528
Merged
Bump Dev Dependencies #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarvNC
commented
Oct 26, 2024
There was a problem hiding this comment.
yomitan/ext/js/dom/document-util.js
Lines 501 to 502 in 0a04fa1
This is broken by the latest typescript update and gets a "why is this @ts-expect-error here" but json.test.js fails without it for some reason. So we can't update Typescript until we figure out why the test is failing without the comment in newer versions of Typescript.
| @@ -38,5 +38,6 @@ | |||
| ], | |||
| "url": "/ext/data/schemas/recommended-dictionaries-schema.json" | |||
| } | |||
| ] | |||
There was a problem hiding this comment.
this is so vscode uses the workspace version of ts and doesn't yell at you about stuff that's erroring in the latest version
jamesmaa
approved these changes
Oct 27, 2024
MarvNC
added
area/dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #802