Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search page displays queried sentence even when parser is off. #1522

Merged

Conversation

austinyu12
Copy link

Addresses #1370. When a parser is on, it will still parse words putting spaces in-between, which is not good for the user, but the result we expect. When all parsers are off, it will now only update text and not parse.

Before, Parser On:
Screenshot 2024-10-20 at 11 22 38 PM

Before, Parser Off:
Screenshot 2024-10-20 at 11 24 49 PM

New Code, Parser On:
Screenshot 2024-10-20 at 11 24 12 PM

New Code, Parser Off:
Screenshot 2024-10-20 at 11 25 13 PM

@austinyu12 austinyu12 requested a review from a team as a code owner October 22, 2024 02:43
Copy link
Collaborator

@jamesmaa jamesmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@jamesmaa jamesmaa added this pull request to the merge queue Oct 22, 2024
Merged via the queue into yomidevs:master with commit ab11521 Oct 22, 2024
11 checks passed
@MarvNC MarvNC added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design area/linguistics The issue or PR is related to linguistics and removed area/ui-ux The issue or PR is related to UI/UX/Design labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/linguistics The issue or PR is related to linguistics kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants