Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cancel button in search page that clears the query #1490

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

tadorituki
Copy link

addressed issue #1460

@tadorituki tadorituki requested a review from a team as a code owner October 14, 2024 02:26
Casheeew
Casheeew previously approved these changes Oct 14, 2024
@Casheeew
Copy link
Member

Can you show a screenshot of the button?

@Casheeew Casheeew dismissed their stale review October 14, 2024 12:03

asking for more information

@tadorituki
Copy link
Author

@Casheeew here is the screenshot
https://github.com/user-attachments/assets/e691e1e4-1c77-4b80-bc28-5dc08f56d89d

Copy link
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather call this Clear since it doesn't actually cancel anything. To me canceling would be clearing the query text and resetting the search results to nothing as well (not what we want here).

@SalwynnJP
Copy link

SalwynnJP commented Oct 14, 2024

It would be better if this button only appears when there is no blank ?

@Kuuuube Kuuuube added this pull request to the merge queue Oct 14, 2024
Merged via the queue into yomidevs:master with commit 1bea0f4 Oct 14, 2024
12 checks passed
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Oct 14, 2024
Copy link

⚠️ Visual differences introduced by this PR; please validate if they are desirable.

View Playwright Report (note: open the "playwright-report" artifact)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants