Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable jsonc/sort-keys on recommended-dictionaries.json, Update recommended-dictionaries-schema.json #1424

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

MarvNC
Copy link
Member

@MarvNC MarvNC commented Sep 17, 2024

Resolves #1402

I do wonder if there's something that can be done so the dictionaries themselves are sorted by name instead of by description.

@MarvNC MarvNC requested a review from a team as a code owner September 17, 2024 03:46
@Casheeew Casheeew added the kind/meta The issue or PR is meta label Sep 17, 2024
@jamesmaa
Copy link
Collaborator

https://ota-meshi.github.io/eslint-plugin-jsonc/rules/sort-keys.html#options I think you can set the order of the dictionaries themselves

Copy link
Member Author

@MarvNC MarvNC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a setting to .vscode/settings.json while I was at it so we get editor checking for correctness using the schema.

@MarvNC MarvNC changed the title Enable jsonc/sort-keys on recommended-dictionaries.json Enable jsonc/sort-keys on recommended-dictionaries.json, Update recommended-dictionaries-schema.json Sep 18, 2024
@jamesmaa jamesmaa enabled auto-merge September 18, 2024 00:12
@jamesmaa jamesmaa added this pull request to the merge queue Sep 18, 2024
Merged via the queue into yomidevs:master with commit 2402390 Sep 18, 2024
9 checks passed
@MarvNC MarvNC deleted the jsonc-sort-keys branch September 18, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use eslint jsonc
3 participants