Added recommended dictionaries from kaikki #1400
Conversation
Kuuuube
added
kind/enhancement
| { | ||
| "name": "kty-zh-en", | ||
| "downloadUrl": "https://github.com/themoeway/kaikki-to-yomitan/releases/latest/download/kty-zh-en.zip", | ||
| "description": "Chinese to English dictionary, provided by kaikki", |
There was a problem hiding this comment.
| "description": "Chinese to English dictionary, provided by kaikki", | |
| "description": "Chinese to English dictionary created from Wiktionary data.", |
Maybe this is clearer? I don't think most people know or care about kaikki
There was a problem hiding this comment.
Is it possible to sort the keys?
There was a problem hiding this comment.
Perfectionist has object key sorting and rules for a bunch of other stuff that can be sorted (in my previous PR I was wondering about sorting switch cases).
There was a problem hiding this comment.
Do you mean sorting it by how it is sorted in the downloads list?
There was a problem hiding this comment.
Do you mean sorting it by how it is sorted in the downloads list?
Nevermind I didnt read Marvs reply .
There was a problem hiding this comment.
Sort the language keys alphabetically so it's easier to find and contribute
There was a problem hiding this comment.
Should I keep Japanese at the top since its mainly a Japanese tool? or just keep the sorting
consistent?
There was a problem hiding this comment.
Seems Perfectionist is for js(x)/ts(x) only, we can use jsonc/sort-keys to sort json. Could look into potentially using the other rules for the other json files we have.
|
CI failing |
* add たまう irregular verb * add たゆたう * more irregular verbs * add kansai-ben tari * bench * add 訪う * remove 負う from irregular verbs * remove incorrect irregular verbs * fix * function to generate irregular inflections * Rename * rename * refactor * lint * naming
* Add volitional slang * typo * update description * remove code from wrong branch * clean up * Apply suggestions from code review Signed-off-by: Khai Truong <[email protected]> * remove code from wrong branch --------- Signed-off-by: Khai Truong <[email protected]>
add teoku form
Head branch was pushed to by a user without write access
Fixes #1331
Added all the languages-en from the provided kaikki dictionary set, Only added the "terms" section for each dictionary, as I didn't know where to get the pronunciation/grammar dictionaries can go back and fix them if I find the dictionaries. Not sure if the titles also suffice or if they should be more precise about which language is being shown