Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add んかった deinflections #1340

Merged
merged 2 commits into from
Aug 24, 2024
Merged

Add んかった deinflections #1340

merged 2 commits into from
Aug 24, 2024

Conversation

Casheeew
Copy link
Member

@Casheeew Casheeew requested a review from a team as a code owner August 23, 2024 14:22
jamesmaa
jamesmaa approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@jamesmaa jamesmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though I'm not super familiar with the verb tabs like v5

@Casheeew
Copy link
Member Author

LGTM. Though I'm not super familiar with the verb tabs like v5

These verb conditions are copied directly from the '-n' rule above, so it should be correct.

@Casheeew Casheeew added this pull request to the merge queue Aug 24, 2024
Merged via the queue into yomidevs:master with commit ebce402 Aug 24, 2024
11 checks passed
@Casheeew Casheeew deleted the nkatta branch August 24, 2024 03:47
@Kuuuube Kuuuube added area/linguistics The issue or PR is related to linguistics kind/enhancement The issue or PR is a new feature or request labels Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmaa jamesmaa jamesmaa approved these changes

Assignees
No one assigned
Labels
area/linguistics The issue or PR is related to linguistics kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ja] - Add deinflection rule for ~んかった
3 participants
@Casheeew @jamesmaa @Kuuuube