-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable download button when dictionary is already installed #1336
Conversation
I'm honestly fine hardcoding for the Jitendex check |
Apart from dictionary |
Great idea! Honestly the download url might be more canonical than title |
We probably do need to keep the check for title. Not all dicts have a download url. |
My BCCWJ does not have a downloadUrl, so I think it's safe to check for both. |
KANJIDIC has dynamic titles now though, are you sure? |
@MarvNC You're right. |
Currently works for KANJIDIC and BCCWJ.
In
recommended-dictionaries.json
, Jitendex has its title hardcoded asJitendex
, but the title of it after installed from the recommended section isJitendex.org [2024-08-11]
. Don't know if we have control over the title of Jitendex,Fixes #1333