Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to Extension Settings not working on Firefox #1335

Merged
merged 1 commit into from
Aug 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ext/issues.html
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,16 @@ <h2 id="audio-download-failed-permissions-error">Audio download failed due to po
This may be due to a permissions issue where Yomitan hasn't been granted access to
the sites hosting the audio files.
</p>
<p>
<p data-hide-for-browser="firefox firefox-mobile">
Check the <em>Site access</em> section of the
<a tabindex="0" class="extension-settings-link" data-special-url="chrome://extensions/?id={id}">extension settings pages</a>
and grant the extension access to <em>all sites</em> or add the specific audio host URLs.
</p>
<p data-show-for-browser="firefox firefox-mobile">
From your browser's address bar, go to <code>about:addons</code> and navigate to the settings for Yomitan.
Check the <em>Site access</em> section of the extension settings pages
and grant the extension access to <em>all sites</em> or add the specific audio host URLs.
</p>
</div></div></div></div>
</div>

Expand Down
5 changes: 4 additions & 1 deletion ext/permissions.html
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,12 @@ <h2 id="permissions"></h2>
<p>
When enabled, Yomitan is able to scan text and show definitions in private/incognito web browser windows.
</p>
<p>
<p data-hide-for-browser="firefox firefox-mobile">
This option can be configured from the web browser's <a tabindex="0" class="extension-settings-link" data-special-url="chrome://extensions/?id={id}">extension settings pages</a>.
</p>
<p data-show-for-browser="firefox firefox-mobile">
This option can be configured from the web browser's extension settings pages. From your browser's address bar, go to <code>about:addons</code> and navigate to the settings for Yomitan.
</p>
</div>
</div>
<div class="settings-item-right">
Expand Down
3 changes: 2 additions & 1 deletion ext/welcome.html
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ <h2><strong>Recommended Permissions &#40;Important&#41;</strong></h2>
</div></div>
<div class="settings-item"><div class="settings-item-inner">
<div class="settings-item-left">
<div class="settings-item-description">Further configuration is available on the <a href="/permissions.html" rel="noopener">Permissions page</a> and the web browser's <a tabindex="0" class="extension-settings-link" data-special-url="chrome://extensions/?id={id}">extension settings page</a>.</div>
<div class="settings-item-description" data-hide-for-browser="firefox firefox-mobile">Further configuration is available on the <a href="/permissions.html" rel="noopener">Permissions page</a> and the web browser's <a tabindex="0" class="extension-settings-link" data-special-url="chrome://extensions/?id={id}">extension settings page</a>.</div>
<div class="settings-item-description" data-show-for-browser="firefox firefox-mobile">Further configuration is available on the <a href="/permissions.html" rel="noopener">Permissions page</a> and the web browser's extension settings page.</div>
<div class="danger-text margin-above" id="permissions-disabled" hidden><strong>Yomitan features will be limited if the recommended permissions are not enabled.</strong></div>
<div class="success-text margin-above" id="recommended-permissions-enabled" hidden><strong>Essential Yomitan features are available.</strong></div>
<div class="success-text margin-above" id="full-permissions-enabled" hidden><strong>All Yomitan features are available.</strong></div>
Expand Down
Loading