Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move search parser option under settings modal #1281

Merged
merged 2 commits into from
Jul 28, 2024
Merged

Move search parser option under settings modal #1281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44f022e
Move search parser option under settings modal
Kuuuube Jul 28, 2024
afefa89
Remove unused css
Kuuuube Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions ext/css/search.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,20 +174,6 @@ h1 {
.search-option-label {
padding-left: 0.5em;
}
.search-option-pre-label {
padding-right: 0.5em;
}
#query-parser-mode-container {
flex: 1 1 auto;
}
#query-parser-mode-container:not([hidden]) {
display: flex;
}
#query-parser-mode-select {
flex: 1 1 auto;
max-width: 220px;
min-width: 100px;
}

/* Search styles */
#intro {
Expand Down
15 changes: 11 additions & 4 deletions ext/search.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ <h1>Yomitan Search</h1>
<label class="toggle"><input type="checkbox" id="clipboard-monitor-enable"><span class="toggle-body"><span class="toggle-track"></span><span class="toggle-knob"></span></span></label>
<span class="search-option-label">Clipboard monitor</span>
</label>
<div class="search-option" id="query-parser-mode-container" hidden>
<span class="search-option-pre-label">Parser:</span>
<select id="query-parser-mode-select"></select>
</div>
</div>
<div class="search-option" id="search-settings-button" data-modal-action="show,search-settings"><span class="icon" data-icon="cog"></span></div>
</div>
Expand Down Expand Up @@ -102,6 +98,17 @@ <h1>Yomitan Search</h1>
<div class="modal-title">Search Settings</div>
</div>
<div class="modal-body">
<div class="settings-item" id="query-parser-mode-container" hidden><div class="settings-item-inner">
<div class="settings-item-left">
<div class="settings-item-label">
Parser
</div>
</div>
<div class="settings-item-right">
<select id="query-parser-mode-select"></select>
</div>
</div></div>

<div class="settings-item" id="search-option-wanakana"><div class="settings-item-inner">
<div class="settings-item-left">
<div class="settings-item-label">
Expand Down
Loading