Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JSON test from static analysis #1216

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

khaitruong922
Copy link

@khaitruong922 khaitruong922 commented Jul 13, 2024

#1206

  • Remove JSON test from test:static-analysis

Fix duplicate JSON test issue on GitHub Actions. Not sure if we want to keep the current command and make a new command without the JSON test for running on GitHub Actions only.

@khaitruong922 khaitruong922 requested a review from a team as a code owner July 13, 2024 15:48
Casheeew
Casheeew previously approved these changes Jul 13, 2024
@Casheeew
Copy link
Member

Casheeew commented Jul 13, 2024

Can change the 'npm-scripts' docs to be more explicit:

'test:static-analysis Runs all of the static analysis tests (excluding JSON).'

@jamesmaa jamesmaa added this pull request to the merge queue Jul 13, 2024
Merged via the queue into yomidevs:master with commit 9928b7a Jul 13, 2024
11 checks passed
@khaitruong922 khaitruong922 deleted the remove-duplicate-test branch July 13, 2024 18:20
@Casheeew Casheeew added the area/ci The issue or PR is related to continuous integration and/or continuous delivery label Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci The issue or PR is related to continuous integration and/or continuous delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants