Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename {selection-text} to {popup-selection-text} #1207

Merged
merged 11 commits into from
Jul 12, 2024

Conversation

khaitruong922
Copy link

@khaitruong922 khaitruong922 commented Jul 12, 2024

#1062

  • Add a field called popup-selection-text to return the same value as selection-text.
  • Remove selection-text from the selection.
  • Migrate new naming to Anki templates and Chrome settings.

@khaitruong922 khaitruong922 requested a review from a team as a code owner July 12, 2024 07:00
@StefanVukovic99
Copy link
Collaborator

I think instead of modifying older handlebars updates this should have a new handlebars update 45 that renames selection text, and an upgrade version function in options util that updates references in existing anki settings.

SelectionText type and variables should also be renamed i guess.

The only mentions of the unprefixed selection-text left would be in the handlebars updates (13, 33, and the new 45), and in the new _updateVersion45.

@StefanVukovic99 StefanVukovic99 added kind/meta The issue or PR is meta area/anki The issue or PR is related to Anki integration labels Jul 12, 2024
@khaitruong922 khaitruong922 marked this pull request as draft July 12, 2024 13:06
@khaitruong922 khaitruong922 marked this pull request as ready for review July 12, 2024 14:44
@Kuuuube Kuuuube added this pull request to the merge queue Jul 12, 2024
Merged via the queue into yomidevs:master with commit 8fc0928 Jul 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/anki The issue or PR is related to Anki integration kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants