Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Option for Scanning Alt Text #1169

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Add Option for Scanning Alt Text #1169

merged 6 commits into from
Jul 3, 2024

Conversation

MarvNC
Copy link
Member

@MarvNC MarvNC commented Jul 2, 2024

Resolves #1149

image

@MarvNC MarvNC requested a review from a team as a code owner July 2, 2024 04:14
Casheeew
Casheeew previously approved these changes Jul 2, 2024
View reviewed changes
StefanVukovic99
StefanVukovic99 reviewed Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@StefanVukovic99 StefanVukovic99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably update options-schema.json and add an update function in OptionsUtil.

@MarvNC
Copy link
Member Author

MarvNC commented Jul 3, 2024

Should probably update options-schema.json and add an update function in OptionsUtil.

Done, not sure how to test though. It just worked for me without adding the function so is it necessary?

@Kuuuube
Copy link
Member

Kuuuube commented Jul 3, 2024

You also need to bump the version in test/options-util.test.js and dw about doing more.

@Kuuuube Kuuuube added the kind/enhancement The issue or PR is a new feature or request label Jul 3, 2024
StefanVukovic99
StefanVukovic99 previously approved these changes Jul 3, 2024
View reviewed changes
ext/js/data/options-util.js Outdated Show resolved Hide resolved
@StefanVukovic99 StefanVukovic99 enabled auto-merge July 3, 2024 09:59
@StefanVukovic99 StefanVukovic99 added this pull request to the merge queue Jul 3, 2024
Merged via the queue into yomidevs:master with commit 066ca66 Jul 3, 2024
11 checks passed
@MarvNC MarvNC deleted the add-dont-scan-image-option branch July 3, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanVukovic99 StefanVukovic99 StefanVukovic99 approved these changes

@Casheeew Casheeew Casheeew left review comments

Assignees
No one assigned
Labels
kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid scanning on images and links for android
4 participants
@MarvNC @Kuuuube @StefanVukovic99 @Casheeew