Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto option to body theme #1086

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Jun 18, 2024

What the auto option does:

  • Welcome, settings, permissions, quick start, search, and info pages all use the browser's default theme
  • The popup adapts theme based on the theme of the webpage it is being rendered on

I've also set this to be the default. It makes the popups much nicer to read since they don't clash with the page they're being rendered on. This should be a nicer experience for new users.

The reason this pr touches frontend, query-parser, and text-scanner is because information from the parent page is required and due to the popup being a separate webpage this cannot easily be accessed. It is being sent through the same way as other information such as the parent page url and sentence (for later use in anki handlebars).

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Jun 18, 2024
@Kuuuube Kuuuube requested a review from a team as a code owner June 18, 2024 21:22
@Kuuuube Kuuuube added this pull request to the merge queue Jun 19, 2024
Merged via the queue into yomidevs:master with commit 451bcab Jun 19, 2024
10 of 11 checks passed
@Kuuuube Kuuuube deleted the auto-body-theme branch June 19, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants