Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the auto option does:
I've also set this to be the default. It makes the popups much nicer to read since they don't clash with the page they're being rendered on. This should be a nicer experience for new users.
The reason this pr touches frontend, query-parser, and text-scanner is because information from the parent page is required and due to the popup being a separate webpage this cannot easily be accessed. It is being sent through the same way as other information such as the parent page url and sentence (for later use in anki handlebars).