forked from FooSoft/yomichan
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support css file in dictionaries #1080
Merged
StefanVukovic99
merged 17 commits into
yomidevs:master
from
StefanVukovic99:dict-styles
Jun 20, 2024
Merged
support css file in dictionaries #1080
StefanVukovic99
merged 17 commits into
yomidevs:master
from
StefanVukovic99:dict-styles
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanVukovic99
added
kind/enhancement
The issue or PR is a new feature or request
area/dictionary-format
The issue or PR is related to dictionary formatting
labels
Jun 18, 2024
Have you checked if anki can import a css file from the html in a field? |
CodSpeed Performance ReportMerging #1080 will not alter performanceComparing Summary
|
This should be done for real now |
Kuuuube
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, appears to work perfectly in my testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/dictionary-format
The issue or PR is related to dictionary formatting
kind/enhancement
The issue or PR is a new feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #542
Example dict (modified jitendex, only word in dict is 明白): testcss5.zip
Any comments on validating or sanitizing are welcome. Also, anything about getting the css in anki.