Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support css file in dictionaries #1080

Merged
merged 17 commits into from
Jun 20, 2024

Conversation

StefanVukovic99
Copy link
Collaborator

Closes #542

Example dict (modified jitendex, only word in dict is 明白): testcss5.zip

Any comments on validating or sanitizing are welcome. Also, anything about getting the css in anki.

@StefanVukovic99 StefanVukovic99 requested a review from a team as a code owner June 18, 2024 14:50
@StefanVukovic99 StefanVukovic99 added kind/enhancement The issue or PR is a new feature or request area/dictionary-format The issue or PR is related to dictionary formatting labels Jun 18, 2024
@Kuuuube
Copy link
Member

Kuuuube commented Jun 18, 2024

Have you checked if anki can import a css file from the html in a field?

Copy link

codspeed-hq bot commented Jun 18, 2024

CodSpeed Performance Report

Merging #1080 will not alter performance

Comparing StefanVukovic99:dict-styles (a6076d5) with master (bba9ceb)

Summary

✅ 4 untouched benchmarks

@StefanVukovic99
Copy link
Collaborator Author

This should be done for real now

Copy link
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, appears to work perfectly in my testing.

@StefanVukovic99 StefanVukovic99 added this pull request to the merge queue Jun 20, 2024
Merged via the queue into yomidevs:master with commit d2c930a Jun 20, 2024
10 checks passed
@StefanVukovic99 StefanVukovic99 deleted the dict-styles branch June 20, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dictionary-format The issue or PR is related to dictionary formatting kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom CSS Distributed With Dictionaries
2 participants