Fix leaking memory due to not improper cleanup of references to detac…

…hed nodes (#1645) * Add missing event listeners removal in element-overflow-controller * Add missing clear dictionaries in element-overflow-controller * Add missing removeAllEventListeners to display-anki _onContentClear
yomidevs · Dec 10, 2024 · e38c1f0 · e38c1f0
1 parent 8f58bf9
commit e38c1f0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/ext/js/display/display-anki.js b/ext/js/display/display-anki.js
@@ -249,6 +249,7 @@ export class DisplayAnki {
         this._updateDictionaryEntryDetailsToken = null;
         this._dictionaryEntryDetails = null;
         this._hideErrorNotification(false);
+        this._eventListeners.removeAllEventListeners();
     }
 
     /** */

diff --git a/ext/js/display/element-overflow-controller.js b/ext/js/display/element-overflow-controller.js
@@ -115,7 +115,9 @@ export class ElementOverflowController {
     /** */
     clearElements() {
         this._elements.length = 0;
+        this._eventListeners.removeAllEventListeners();
         this._windowEventListeners.removeAllEventListeners();
+        this._dictionaries.clear();
     }
 
     // Private