Skip to content

Commit

Permalink
shared-modals
Browse files Browse the repository at this point in the history
  • Loading branch information
khaitruong922 committed Sep 21, 2024
1 parent 9d3f06b commit c0d47b6
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 17 deletions.
2 changes: 1 addition & 1 deletion ext/js/pages/settings/settings-main.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ await Application.main(true, async (application) => {

const preparePromises = [];

const modalController = new ModalController(['welcome-modals', 'settings-modals']);
const modalController = new ModalController(['shared-modals', 'settings-modals']);
await modalController.prepare();

const settingsController = new SettingsController(application);
Expand Down
30 changes: 15 additions & 15 deletions ext/js/pages/welcome-main.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,20 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

import {Application} from '../application.js';
import {DocumentFocusController} from '../dom/document-focus-controller.js';
import {querySelectorNotNull} from '../dom/query-selector.js';
import {ExtensionContentController} from './common/extension-content-controller.js';
import {DictionaryController} from './settings/dictionary-controller.js';
import {DictionaryImportController} from './settings/dictionary-import-controller.js';
import {GenericSettingController} from './settings/generic-setting-controller.js';
import {LanguagesController} from './settings/languages-controller.js';
import {ModalController} from './settings/modal-controller.js';
import {RecommendedPermissionsController} from './settings/recommended-permissions-controller.js';
import {ScanInputsSimpleController} from './settings/scan-inputs-simple-controller.js';
import {SettingsController} from './settings/settings-controller.js';
import {SettingsDisplayController} from './settings/settings-display-controller.js';
import {StatusFooter} from './settings/status-footer.js';
import { Application } from '../application.js';

Check failure on line 19 in ext/js/pages/welcome-main.js

View workflow job for this annotation

GitHub Actions / Static Analysis

There should be no space after '{'

Check failure on line 19 in ext/js/pages/welcome-main.js

View workflow job for this annotation

GitHub Actions / Static Analysis

There should be no space before '}'
import { DocumentFocusController } from '../dom/document-focus-controller.js';

Check failure on line 20 in ext/js/pages/welcome-main.js

View workflow job for this annotation

GitHub Actions / Static Analysis

There should be no space after '{'

Check failure on line 20 in ext/js/pages/welcome-main.js

View workflow job for this annotation

GitHub Actions / Static Analysis

There should be no space before '}'
import { querySelectorNotNull } from '../dom/query-selector.js';

Check failure on line 21 in ext/js/pages/welcome-main.js

View workflow job for this annotation

GitHub Actions / Static Analysis

There should be no space after '{'

Check failure on line 21 in ext/js/pages/welcome-main.js

View workflow job for this annotation

GitHub Actions / Static Analysis

There should be no space before '}'
import { ExtensionContentController } from './common/extension-content-controller.js';

Check failure on line 22 in ext/js/pages/welcome-main.js

View workflow job for this annotation

GitHub Actions / Static Analysis

There should be no space after '{'

Check failure on line 22 in ext/js/pages/welcome-main.js

View workflow job for this annotation

GitHub Actions / Static Analysis

There should be no space before '}'
import { DictionaryController } from './settings/dictionary-controller.js';

Check failure on line 23 in ext/js/pages/welcome-main.js

View workflow job for this annotation

GitHub Actions / Static Analysis

There should be no space after '{'

Check failure on line 23 in ext/js/pages/welcome-main.js

View workflow job for this annotation

GitHub Actions / Static Analysis

There should be no space before '}'
import { DictionaryImportController } from './settings/dictionary-import-controller.js';
import { GenericSettingController } from './settings/generic-setting-controller.js';
import { LanguagesController } from './settings/languages-controller.js';
import { ModalController } from './settings/modal-controller.js';
import { RecommendedPermissionsController } from './settings/recommended-permissions-controller.js';
import { ScanInputsSimpleController } from './settings/scan-inputs-simple-controller.js';
import { SettingsController } from './settings/settings-controller.js';
import { SettingsDisplayController } from './settings/settings-display-controller.js';
import { StatusFooter } from './settings/status-footer.js';

/**
* @param {import('../comm/api.js').API} api
Expand Down Expand Up @@ -60,7 +60,7 @@ async function checkNeedsCustomTemplatesWarning() {
}

await Application.main(true, async (application) => {
const modalController = new ModalController(['welcome-modals']);
const modalController = new ModalController(['shared-modals']);
await modalController.prepare();

const settingsController = new SettingsController(application);
Expand Down
2 changes: 1 addition & 1 deletion ext/templates-modals.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<!DOCTYPE html><html><head><title>Templates</title></head><body>

<template id="welcome-modals-template">
<template id="shared-modals-template">
<div id="dictionaries-modal" class="modal" tabindex="-1" role="dialog" hidden><div class="modal-content">
<div class="modal-header">
<div class="modal-title">Dictionaries</div>
Expand Down

0 comments on commit c0d47b6

Please sign in to comment.