Don't scan alt text if option disabled

yomidevs · Jul 2, 2024 · b88b97c · b88b97c
1 parent 0f3447a
commit b88b97c
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/ext/js/language/text-scanner.js b/ext/js/language/text-scanner.js
@@ -449,6 +449,11 @@ export class TextScanner extends EventDispatcher {
      */
     async _search(textSource, searchTerms, searchKanji, inputInfo, showEmpty = false) {
         try {
+            const isAltText = textSource instanceof TextSourceElement;
+            if (isAltText && !this._scanAltText) {
+                return;
+            }
+
             const inputInfoDetail = inputInfo.detail;
             const selectionRestoreInfo = (
                 (typeof inputInfoDetail === 'object' && inputInfoDetail !== null && inputInfoDetail.restoreSelection) ?
@@ -474,7 +479,7 @@ export class TextScanner extends EventDispatcher {
             const result = await this._findDictionaryEntries(textSource, searchTerms, searchKanji, optionsContext);
             if (result !== null) {
                 ({dictionaryEntries, sentence, type} = result);
-            } else if (showEmpty || (textSource !== null && textSource instanceof TextSourceElement && await this._isTextLookupWorthy(textSource.fullContent))) {
+            } else if (showEmpty || (textSource !== null && isAltText && await this._isTextLookupWorthy(textSource.fullContent))) {
                 // Shows a "No results found" message
                 dictionaryEntries = [];
                 sentence = {text: '', offset: 0};