update test

yomidevs · Dec 29, 2023 · b5ea86f · b5ea86f
1 parent 79b02b1
commit b5ea86f
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/ext/js/data/options-util.js b/ext/js/data/options-util.js
@@ -555,7 +555,8 @@ export class OptionsUtil {
             this._updateVersion19,
             this._updateVersion20,
             this._updateVersion21,
-            this._updateVersion22
+            this._updateVersion22,
+            this._updateVersion23
         ];
         if (typeof targetVersion === 'number' && targetVersion < result.length) {
             result.splice(targetVersion);
@@ -1144,6 +1145,18 @@ export class OptionsUtil {
         return options;
     }
 
+    /**
+     * - Added translation.partsOfSpeechFilter.
+     * @type {import('options-util').UpdateFunction}
+     */
+    _updateVersion23(options) {
+        for (const {options: profileOptions} of options.profiles) {
+            profileOptions.translation.partsOfSpeechFilter = true;
+        }
+
+        return options;
+    }
+
     /**
      * @param {string} url
      * @returns {Promise<chrome.tabs.Tab>}

diff --git a/ext/settings.html b/ext/settings.html
@@ -1524,7 +1524,7 @@ <h1>Yomitan Settings</h1>
                 </div>
                 <div class="settings-item-description">
                     <p>
-                        Filter algorithm deinflections using part of speech tags.
+                        Dictionary entries will be filtered out if their PoS doesn't match the PoS expected by the deinflector.
                     </p>
                 </div>
             </div>

diff --git a/test/options-util.test.js b/test/options-util.test.js
@@ -413,6 +413,7 @@ function createProfileOptionsUpdatedTestData1() {
             convertHiraganaToKatakana: 'false',
             convertKatakanaToHiragana: 'variant',
             collapseEmphaticSequences: 'false',
+            partsOfSpeechFilter: true,
             searchResolution: 'letter',
             textReplacements: {
                 searchOriginal: true,
@@ -602,7 +603,7 @@ function createOptionsUpdatedTestData1() {
             }
         ],
         profileCurrent: 0,
-        version: 22,
+        version: 23,
         global: {
             database: {
                 prefixWildcardsSupported: false
-Original file line number
+Diff line change
@@ Expand Up / @@ -1524,7 +1524,7 @@ <h1>Yomitan Settings</h1> @@
                     </div>
                     <div class="settings-item-description">
                         <p>
-                            Filter algorithm deinflections using part of speech tags.
+                            Dictionary entries will be filtered out if their PoS doesn't match the PoS expected by the deinflector.
                         </p>
                     </div>
                 </div>
@@ Expand Down @@