Remove unnecessary eslint global declarations (#430)

yomidevs · Dec 23, 2023 · 76c52d2 · 76c52d2
1 parent a72b53d
commit 76c52d2
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 62 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -587,68 +587,6 @@
                 "webextensions": false
             }
         },
-        {
-            "files": [
-                "ext/**/*.js"
-            ],
-            "excludedFiles": [
-                "ext/js/core/extension-error.js"
-            ],
-            "globals": {
-                "ExtensionError": "readonly"
-            }
-        },
-        {
-            "files": [
-                "ext/**/*.js"
-            ],
-            "excludedFiles": [
-                "ext/js/core.js",
-                "ext/js/core/extension-error.js",
-                "ext/js/accessibility/google-docs.js",
-                "ext/js/**/sandbox/**/*.js"
-            ],
-            "globals": {
-                "isObject": "readonly",
-                "stringReverse": "readonly",
-                "promiseTimeout": "readonly",
-                "escapeRegExp": "readonly",
-                "deferPromise": "readonly",
-                "clone": "readonly",
-                "deepEqual": "readonly",
-                "generateId": "readonly",
-                "promiseAnimationFrame": "readonly",
-                "invokeMessageHandler": "readonly",
-                "log": "readonly",
-                "DynamicProperty": "readonly",
-                "EventDispatcher": "readonly",
-                "EventListenerCollection": "readonly",
-                "Logger": "readonly"
-            }
-        },
-        {
-            "files": [
-                "ext/**/*.js"
-            ],
-            "excludedFiles": [
-                "ext/js/core.js",
-                "ext/js/core/extension-error.js",
-                "ext/js/accessibility/google-docs.js",
-                "ext/js/yomitan.js",
-                "ext/js/**/sandbox/**/*.js"
-            ],
-            "globals": {
-                "yomitan": "readonly"
-            }
-        },
-        {
-            "files": [
-                "ext/js/yomitan.js"
-            ],
-            "globals": {
-                "chrome": "writable"
-            }
-        },
         {
             "files": [
                 "test/**/*.js",

diff --git a/ext/js/yomitan.js b/ext/js/yomitan.js
@@ -38,6 +38,7 @@ if ((() => {
     return (hasBrowser && !hasChrome);
 })()) {
     // @ts-expect-error - objects should have roughly the same interface
+    // eslint-disable-next-line no-global-assign
     chrome = browser;
 }