remove redundancy in cache-map (#485)

* remove redundancy * fix lint
yomidevs · Dec 29, 2023 · 59961b6 · 59961b6
1 parent 0886252
commit 59961b6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/ext/js/general/cache-map.js b/ext/js/general/cache-map.js
@@ -29,7 +29,6 @@ export class CacheMap {
      */
     constructor(maxSize) {
         if (!(
-            typeof maxSize === 'number' &&
             Number.isFinite(maxSize) &&
             maxSize >= 0 &&
             Math.floor(maxSize) === maxSize

diff --git a/test/cache-map.test.js b/test/cache-map.test.js
@@ -31,9 +31,7 @@ function testConstructor() {
             [true,  () => new CacheMap(-1)],
             [true,  () => new CacheMap(1.5)],
             [true,  () => new CacheMap(Number.NaN)],
-            [true,  () => new CacheMap(Number.POSITIVE_INFINITY)],
-            // @ts-expect-error - Ignore because it should throw an error
-            [true,  () => new CacheMap('a')]
+            [true,  () => new CacheMap(Number.POSITIVE_INFINITY)]
         ];
 
         for (const [throws, create] of data) {