Merge remote-tracking branch 'origin/master' into performance-canvas

.eslintrc.json

@@ -643,8 +643,10 @@
                 "ext/js/language/de/german-text-preprocessors.js",
                 "ext/js/language/de/german-transforms.js",
                 "ext/js/language/en/english-transforms.js",
+                "ext/js/language/eo/esperanto-transforms.js",
                 "ext/js/language/es/spanish-transforms.js",
                 "ext/js/language/fr/french-text-preprocessors.js",
+                "ext/js/language/fr/french-transforms.js",
                 "ext/js/language/ja/japanese-text-preprocessors.js",
                 "ext/js/language/ja/japanese-transforms.js",
                 "ext/js/language/ja/japanese-wanakana.js",

README.md

@@ -77,12 +77,12 @@ Since this is a distributed effort, we **highly welcome new contributors**! Feel
 Here are some ways anyone can help:
 
 - Try using the Yomitan dev build. Not only do you get cutting edge features, but you can help uncover bugs and give feedback to developers early on.
-- Document any UI/UX friction in Github Issues. We're looking to make Yomitan more accessible to non-technical users.
+- Document any UI/UX friction in GitHub Issues. We're looking to make Yomitan more accessible to non-technical users.
 - All the issues in `area/bug` older than 2 months need help reproducing. If anything interests you, please try to reproduce it and report your results. We can't easily tell if these issues are one-off, have since been resolved, or are no longer relevant.
 
 > The current active maintainers of Yomitan spend a lot of their time debugging and triaging issues. When someone files a bug report, we need to assess the frequency and severity of the bug. It is extremely helpful if we get multiple reports of people who experience a bug or people who can contribute additional detail to an existing bug report.
 
-If you're looking to code, please let us know what you plan on working on before submitting a Pull Request. This gives the core maintainers an opportunity to provide feedback early on before you dive too deep. You can do this by opening a Github Issue with the proposal.
+If you're looking to code, please let us know what you plan on working on before submitting a Pull Request. This gives the core maintainers an opportunity to provide feedback early on before you dive too deep. You can do this by opening a GitHub Issue with the proposal.
 
 Some contributions we always appreciate:
 

docs/development/language-features.md

@@ -414,4 +414,4 @@ In certain languages, dictionary entries may contain readings as a key to read w
 
 ## Stuck?
 
-If you have any questions, please feel free to open a Discussion on Github, or find us on the [Yomitan Discord](https://discord.gg/YkQrXW6TXF).
+If you have any questions, please feel free to open a Discussion on GitHub, or find us on the [Yomitan Discord](https://discord.gg/YkQrXW6TXF).

docs/operations/deployments.md

@@ -1,6 +1,6 @@
 # Deployments
 
-We deploy yomitan to the Firefox and Chrome webstore via two channels -- the dev build and the stable build. We do this via a series of Github Actions.
+We deploy yomitan to the Firefox and Chrome webstore via two channels -- the dev build and the stable build. We do this via a series of GitHub Actions.
 
 Only collaborators with deployment permissions are allowed to deploy.
 

ext/action-popup.html

@@ -42,7 +42,7 @@ <h2 class="action-title">Profile</h2>
                 <p class="tooltip">Hover over text to scan</p>
             </div>
         </div>
-        <div class="action-container">
+        <div class="action-container action-buttons">
             <button tabindex="0" type="button" class="low-emphasis action-open-settings" title="Settings" data-hotkey='["global:openSettingsPage","title","Settings ({0})"]'>
                 <div class="action-icon">
                     <span class="icon" data-icon="cog"></span>

ext/css/action-popup.css

@@ -53,7 +53,7 @@ body:not([data-loaded=true]) #action-popup {
 }
 
 body {
-    padding: 10px;
+    padding: 5px;
     margin: 0;
     font-family: 'Segoe UI', Tahoma, sans-serif;
     font-size: var(--font-size);
@@ -254,14 +254,17 @@ h2.action-title {
     display: flex;
     justify-content: space-between;
     align-items: center;
-    padding: 10px;
-    gap: 0.25em;
+    padding: 5px;
 }
 
 .action-container button {
     flex: 0 0 auto;
 }
 
+.action-container.action-buttons {
+    gap: 0.25em;
+}
+
 /* Actions */
 
 .action-container.action-select-profile {
@@ -287,7 +290,7 @@ select.profile-select {
     color: #808080;
     padding: 0;
     margin: 0;
-    margin-top: 0.5em;
+    margin-top: 0.25em;
 }
 
 .enable-dictionary-tooltip {

ext/css/visibility-modifiers.css

@@ -13,3 +13,6 @@
 :root:is([data-language=ja], [data-language=zh], [data-language=yue], [data-language=ko]) .not-jpzhyueko {
     display: none;
 }
+:root:not([data-language=ja]) .jp-only {
+    display: none;
+}

ext/info.html

@@ -68,9 +68,9 @@ <h2 id="links">Links</h2>
             <ul>
                 <li>Information and user guide: <a href="https://yomitan.wiki" rel="noreferrer noopener">Homepage</a></li>
                 <li>Recommended dictionaries: <a href="https://yomitan.wiki/dictionaries/">Yomitan Dictionaries</a></li>
-                <li>Source code: <a href="https://github.com/yomidevs/yomitan" rel="noreferrer noopener">Github</a></li>
+                <li>Source code: <a href="https://github.com/yomidevs/yomitan" rel="noreferrer noopener">GitHub</a></li>
                 <li>Release notes: <a href="https://github.com/yomidevs/yomitan/releases" rel="noreferrer noopener" data-href-format="https://github.com/yomidevs/yomitan/releases/tag/{version}" id="release-notes-this-version-link">This version</a> | <a href="https://github.com/yomidevs/yomitan/releases" rel="noreferrer noopener">All versions</a></li>
-                <li>Bugs? Report them here: <a href="https://github.com/yomidevs/yomitan/issues/new/choose" rel="noreferrer noopener">Github Issues</a></li>
+                <li>Bugs? Report them here: <a href="https://github.com/yomidevs/yomitan/issues/new/choose" rel="noreferrer noopener">GitHub Issues</a></li>
                 <li>More extension information: <a href="https://yomitan.wiki/privacy/">Permissions</a> | <a href="/legal.html">Licenses</a> | <a href="/issues.html">Issues</a></li>
                 <li>Enjoying Yomitan? Help us by leaving a review on the Firefox/Chrome/Edge store! <a href="https://addons.mozilla.org/en-US/firefox/addon/yomitan/">Firefox</a> | <a href="https://chromewebstore.google.com/detail/yomitan/likgccmbimhjbgkjambclfkhldnlhbnn">Chrome</a> | <a href="https://microsoftedge.microsoft.com/addons/detail/yomitan/idelnfbbmikgfiejhgmddlbkfgiifnnn">Edge</a></li>
             </ul>

ext/js/display/element-overflow-controller.js

@@ -117,7 +117,6 @@ export class ElementOverflowController {
         this._elements.length = 0;
         this._eventListeners.removeAllEventListeners();
         this._windowEventListeners.removeAllEventListeners();
-        this._dictionaries.clear();
     }
 
     // Private