Merge pull request #311 from jbukl/pw-esm-fix

yomidevs · Nov 9, 2023 · 2cd7b14 · 2cd7b14
2 parents c25e4c9 + 41cff83
commit 2cd7b14
Show file tree

Hide file tree

Showing 11 changed files with 23 additions and 35 deletions.
diff --git a/.env b/.env
@@ -0,0 +1 @@
+PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS=1
diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
@@ -9,8 +9,6 @@ jobs:
   playwright:
     timeout-minutes: 60
     runs-on: ubuntu-latest
-    env:
-      PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS: 1
     steps:
       - name: Remove all fonts
         run: rm -rf /usr/share/fonts

diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -6,8 +6,5 @@
         "source.fixAll.eslint": true,
     },
     "eslint.format.enable": true,
-    "playwright.env": {
-        "PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS": 1
-    },
     "javascript.preferences.importModuleSpecifierEnding": "js",
 }
diff --git a/ext/js/display/display-audio.js b/ext/js/display/display-audio.js
@@ -21,11 +21,6 @@ import {PopupMenu} from '../dom/popup-menu.js';
 import {AudioSystem} from '../media/audio-system.js';
 import {yomichan} from '../yomichan.js';
 
-/* global
- * AudioSystem
- * PopupMenu
- */
-
 export class DisplayAudio {
     constructor(display) {
         this._display = display;

diff --git a/ext/js/display/popup-main.js b/ext/js/display/popup-main.js
@@ -27,17 +27,6 @@ import {DisplayProfileSelection} from './display-profile-selection.js';
 import {DisplayResizer} from './display-resizer.js';
 import {Display} from './display.js';
 
-/* global
- * Display
- * DisplayAnki
- * DisplayAudio
- * DisplayProfileSelection
- * DisplayResizer
- * DocumentFocusController
- * HotkeyHandler
- * JapaneseUtil
- */
-
 (async () => {
     try {
         const documentFocusController = new DocumentFocusController();

diff --git a/ext/js/pages/settings/dictionary-controller.js b/ext/js/pages/settings/dictionary-controller.js
@@ -20,10 +20,6 @@ import {EventListenerCollection, log} from '../../core.js';
 import {DictionaryWorker} from '../../language/dictionary-worker.js';
 import {yomichan} from '../../yomichan.js';
 
-/* global
- * DictionaryWorker
- */
-
 class DictionaryEntry {
     constructor(dictionaryController, fragment, index, dictionaryInfo) {
         this._dictionaryController = dictionaryController;

diff --git a/ext/js/pages/settings/popup-preview-frame-main.js b/ext/js/pages/settings/popup-preview-frame-main.js
@@ -22,12 +22,6 @@ import {HotkeyHandler} from '../../input/hotkey-handler.js';
 import {yomichan} from '../../yomichan.js';
 import {PopupPreviewFrame} from './popup-preview-frame.js';
 
-/* global
- * HotkeyHandler
- * PopupFactory
- * PopupPreviewFrame
- */
-
 (async () => {
     try {
         await yomichan.prepare();

diff --git a/ext/js/templates/sandbox/template-renderer-media-provider.js b/ext/js/templates/sandbox/template-renderer-media-provider.js
@@ -16,9 +16,7 @@
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-/* global
- * Handlebars
- */
+import {Handlebars} from '../../../lib/handlebars.js';
 
 export class TemplateRendererMediaProvider {
     constructor() {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -43,6 +43,7 @@
         "css": "^3.0.0",
         "dexie": "^3.2.4",
         "dexie-export-import": "^4.0.7",
+        "dotenv": "^16.3.1",
         "esbuild": "^0.19.5",
         "eslint": "^8.52.0",
         "eslint-plugin-header": "^3.1.1",

diff --git a/playwright.config.js b/playwright.config.js
@@ -21,7 +21,7 @@ import {defineConfig, devices} from '@playwright/test';
  * Read environment variables from file.
  * https://github.com/motdotla/dotenv
  */
-// require('dotenv').config();
+import 'dotenv/config';
 
 /**
  * @see https://playwright.dev/docs/test-configuration
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS=1