Fix dictionary move to index (#514)

* Fix dictionary move to index * Use number isnan
yomidevs · Jan 13, 2024 · 2aea929 · 2aea929
1 parent 36c40ff
commit 2aea929
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/ext/js/pages/settings/dictionary-controller.js b/ext/js/pages/settings/dictionary-controller.js
@@ -716,9 +716,9 @@ export class DictionaryController {
     /** */
     _onDictionaryMoveButtonClick() {
         const modal = /** @type {import('./modal.js').Modal} */ (this._modalController.getModal('dictionary-move-location'));
-        const {index} = modal.node.dataset;
-        if (typeof index !== 'number') { return; }
+        const index = modal.node.dataset.index ?? '';
         const indexNumber = Number.parseInt(index, 10);
+        if (Number.isNaN(indexNumber)) { return; }
 
         /** @type {HTMLInputElement} */
         const targetStringInput = querySelectorNotNull(document, '#dictionary-move-location');