Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update french tag_bank_term.json #80

Merged
merged 3 commits into from
Jun 23, 2024
Merged

Update french tag_bank_term.json #80

merged 3 commits into from
Jun 23, 2024

Conversation

Ceynou
Copy link
Contributor

@Ceynou Ceynou commented Jun 21, 2024

So I checked the skippedTermTags file and I retained, I hope, the most important tags.

verlan: somehow the reverse of a word, like meuf, ouf and rebeu are verlan for femme, fou and arabe.

abus de langage: commonly(but wrongly)

usage critiqué: criticized usage, could be under commonly

impropre: improper

non standard: ...

par confusion: mistakenly

tort: wrongly

you can change them if you want.

@StefanVukovic99
Copy link
Collaborator

Thanks for the PR! You might want to look out for tags with the same name:

[
     "abus de langage",
     "",
     0,
     "Par abus",
     0
   ],
   [
     "abus de langage",
     "",
     0,
     "Usage abusif",
     0
   ]

Both of these kaikki/wiktionary tags ,Par abus and Usage abusif, will be shown in yomitan as abus de langage, but when you click the tag in yomitan to get the popup it will return the first full tag with that name, so it will always show, say Par abus. (It may also be the other one, depends on the order they get inserted into tag_bank_1). If you want to keep the original full text separately, then they need different short texts. If you are ok with one being lost, you can choose the full tag text by writing in tag_bank_term:

   [
     "abus de langage",
     "",
     0,
    ["Par abus",  "Usage abusif"]
     0
   ]

Now they will both be shown as abus de language and the full tag will be the first in the array, Par abus. (This is not valid format for Yomitan tags, i added this to kaikki's tag_bank_term as a way to define aliases).

Other than that, not sure if works in French, but shorter tags usually look better. Maybe just abus? You can try both ways and see which looks better in Yomitan.

@StefanVukovic99 StefanVukovic99 merged commit 3f884af into yomidevs:master Jun 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants