Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Fix product name calculation error #23

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Chore: Fix product name calculation error #23

merged 1 commit into from
Jan 10, 2025

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Fix arguments in product name calculation.

Testing notes:

  1. Create package, upload to server and use in bundle.
  2. Open publisher.
  3. New instances should have correctly calculated product name.
  4. Change of context on existing instances should properly fill product name.

Resolves #2

@iLLiCiTiT iLLiCiTiT self-assigned this Jan 9, 2025
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Jan 9, 2025
@iLLiCiTiT iLLiCiTiT merged commit 3405163 into develop Jan 10, 2025
5 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/2-arguments-in-create-plugin branch January 10, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@64qam 64qam 64qam approved these changes

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

@MilaKudr MilaKudr Awaiting requested review from MilaKudr

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arguments in Create plugin
2 participants
@iLLiCiTiT @64qam