-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loader: Implement existing product group picker in Group Products dialog #668
Open
BigRoy
wants to merge
17
commits into
ynput:develop
Choose a base branch
from
BigRoy:enhancement/product_group_add_existing_group_picker
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b88430b
Implement existing product group picker in Group Products dialog, fix…
BigRoy 7af3d22
Add as widget instead of layout
BigRoy 924fe18
Go through controller for product groups query
BigRoy eca2e7e
Update client/ayon_core/tools/loader/ui/product_group_dialog.py
BigRoy 587665b
Move more logic to `LoaderController`
BigRoy 8ba991f
Merge branch 'develop' into enhancement/product_group_add_existing_gr…
BigRoy 0b2ac16
Merge branch 'enhancement/product_group_add_existing_group_picker' of…
BigRoy df9985b
Merge branch 'develop' into enhancement/product_group_add_existing_gr…
BigRoy 042b3f9
Merge branch 'develop' into enhancement/product_group_add_existing_gr…
BigRoy 3372fee
Merge branch 'develop' into enhancement/product_group_add_existing_gr…
BigRoy 1191e13
Fix parenting
BigRoy 4de74bf
List the existing groups in sorted order
BigRoy 1e86602
Cosmetics
BigRoy f533554
Use `HintedLineEdit`
BigRoy a5daf3d
Merge branch 'enhancement/product_group_add_existing_group_picker' of…
BigRoy 90b4344
Fix typo
BigRoy aafab4b
pass in folder ids with product ids
iLLiCiTiT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-fill group field value based on selection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The listed product groups are ALL groups under the active folders - not just the groups of the products in your selection. Just so that you can easily move it into another group outside of your selection.
So technically, this would first have to get all the product entities, get their product groups - then from those pick the first entry (or most used entry)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, right now it's prefilled with previous value of the widget. So either we use first, or empty string, or most common, but current behavior is not correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder...