Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher: Promote information to be shown on instance label #167

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bradenjennings
Copy link
Contributor

@bradenjennings bradenjennings commented Mar 11, 2024

Changelog Description

We need to be able to display more information on instance label in publisher than just it's name.

image
In this case for example renderCompositingMain could show there also frame range or some badge that review will be created.

What information shown there could be decided by plugins themselves. But how to solve conflicting interests, available ways to show things, etc. is up to the implementation.

Please see this ticket for more info: https://app.clickup.com/t/6658547/AY-2474

Additional info

Paragraphs of text giving context of additional technical information or code examples.

Testing notes:

  1. start with this step
  2. follow this step

@ynbot ynbot added type: feature Adding something new and exciting to the product size/XS host: Maya labels Mar 11, 2024
@bradenjennings
Copy link
Contributor Author

bradenjennings commented Mar 11, 2024

I wasn't sure how to approach this ticket.

So for now I've added an extra label attribute which can be implemented in the creator plugin.
The problem is I can't return anything useful from the creator plugin method get_extra_label, such as frame range.

image

I'm hardcoding the frame range for now, for the purpose of demonstration.

Any guidance would be appreciated.

@bradenjennings bradenjennings marked this pull request as draft March 11, 2024 03:58
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Mar 12, 2024

It should not be done via a method on a create plugin, it does not make much sense, you want to show the information per instance and get the information from instance. But there already is a way how to approach it, just fill "label" key in data. That is not enough?

@BigRoy
Copy link
Collaborator

BigRoy commented Mar 12, 2024

It should not be done via a method on a create plugin, it does not make much sense, you want to show the information per instance and get the information from instnace. But there already is a way how to approach it, just fill "label" key in data. That is not enough?

I believe the original new publisher designs had a special layout for the cards to e.g. show the frame range below the instance's name, and potentially make room for other info:

  • frame ranges
  • asset + task names
  • enabled output types
  • etc.

Anyway, what's suitable info for there I guess isn't really defined. Maybe @mkolar has a good link to some of those designs (and can debate whether they are still relevant or not).

Just wanted to remark that even if frame range would be in the label - it'd still need to update when e.g. frame range attributes would be "changed" on e.g. creator attributes or publish attributes if those frame ranges are defined there - and not collect or whatever? (Again coming back to the "update on attribute changes"?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Maya size/XS type: feature Adding something new and exciting to the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote information to be shown on instance label in Publisher
4 participants