Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher: Report page can stretch logs #1104

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Report page can be stretched so long logs should be accessible.

Additional info

Set minimum size of content widget to be able to stretch it's size.

Testing notes:

  1. Long logs on Report page can be readable.

@iLLiCiTiT iLLiCiTiT added community Issues and PRs coming from the community members type: enhancement Improvement of existing functionality or minor addition labels Jan 24, 2025
@iLLiCiTiT iLLiCiTiT self-assigned this Jan 24, 2025
@iLLiCiTiT iLLiCiTiT requested a review from BigRoy January 24, 2025 13:28
@ynbot ynbot added the size/XS label Jan 24, 2025
@alainxi
Copy link

alainxi commented Jan 24, 2025

I tested this PR, but long logs are still not readable (report page cannot be stretched).
And it added unexpected vertical space between the first lines.

compare2

@alainxi
Copy link

alainxi commented Jan 24, 2025

Instead, in the same function, I tried to activate horizontal scroll bar :

scroll_area.setHorizontalScrollBarPolicy(QtCore.Qt.ScrollBarAsNeeded)

While it allows to see very long lines, it kills word wrap for the rest of the page.
So, moderately long lines cannot be seen at first glance anymore (because word wrap is dead), you now need to use the scroll bar for a lot of lines, which is far from ideal.

@alainxi
Copy link

alainxi commented Jan 24, 2025

Thanks !
The WrapAtWordBoundaryOrAnywhere works, now everything is wraped.

But there is a catch : now, all the \n are ignored, so the nice readable layout is gone :

compare4

@alainxi
Copy link

alainxi commented Jan 24, 2025

I found a solution to still use line returns : I replace \n by <br/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants