Refactor OTIO frame range collection #1060
Open
+121
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unused function import. - Added detailed logging for data updates. - Streamlined frame range calculations and handling. - Introduced a new class for collecting source frame ranges. - Improved readability by cleaning up code structure.
|
Task linked: AY-7125 Advanced Editorial publish to AYON |
ynbot
added
type: feature
iLLiCiTiT
reviewed
Dec 17, 2024
iLLiCiTiT
reviewed
Dec 17, 2024
robin-ynput
reviewed
Dec 17, 2024
There was a problem hiding this comment.
I gave it a try through Hiero and confirmed it still all works perfectly.
My only concern would be implementation-wise, currently it does:
Collect OTIO Frame Ranges [resolve, hiero, flame, traypublisher]:
* frameStart
* frameEnd
* clipIn
* clipOut
* clipInH
* clipOutH
then
Collect OTIO Frame Ranges (with media range) [hiero, flame]:
* frameStart (same value)
* frameEnd (retimed or same value)
* clipIn (same value)
* clipOut (same value)
* clipInH (same value)
* clipOutH (same value)
* sourceStart
* sourceEnd
* sourceStartH
* sourceEndH
I feel like there is quite some code duplication but more importantly to keep a single source of truth, I'd rather prefer to have :
Collect OTIO Frame Ranges [resolve, hiero, flame, traypublisher]:
* frameStart
* frameEnd
* clipIn
* clipOut
* clipInH
* clipOutH
then
Collect Source OTIO Frame Ranges [hiero, flame]:
* sourceStart
* sourceEnd
* sourceStartH
* sourceEndH
and
Collect Retimed OTIO Frame Ranges [hiero, flame]:
* frameEnd (if retimed)
What do you think ?
|
I would like to avoid hosts filtering completelly if possible, but that would probably require more changes.... |
- Added validation function for OTIO clips. - Improved documentation for each plugin. - Enhanced logging to provide clearer debug messages. - Separated logic for collecting timeline, source, and retimed ranges into distinct classes. - Updated frame calculations to handle retimed clips more effectively.
- Removed type hints for `Any` in function definitions. - Simplified the `validate_otio_clip` and `process` methods across multiple classes. - Cleaned up code for better readability without changing functionality.
iLLiCiTiT
reviewed
Jan 14, 2025
iLLiCiTiT
reviewed
Jan 14, 2025
iLLiCiTiT
reviewed
Jan 14, 2025
iLLiCiTiT
reviewed
Jan 23, 2025
Co-authored-by: Jakub Trllo <[email protected]>
Merged multiple plugins into a single one for collecting OTIO frame ranges. - Unified handling of timeline, source media, and retimed clip ranges. - Updated class name and docstrings for clarity. - Simplified process method to streamline range collection logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Additional info
Testing notes:
All should work as before
Blocking ynput/ayon-traypublisher#58