port RcppCore/RcppEigen#131, adapted to Eigen 3.4.0 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I didn't touch the patch files, somewhat on purpose, due to the |
|
This makes perfect sense. Thanks! Let me merge it first. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, RcppEigen would have had a branch applying the RcppCore#102 changes. Well, this second-order PR should ensure that the first-order PR plays nicely with Matrix >= 1.6-2, including the forthcoming Matrix 1.7-0. At the very least, OpenMx and lme4 pass their checks (modulo
-Wallissues beyond the scope of this PR).I'll leave merging of changes from
masterto others.@eddelbuettel @yixuan