Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to restore original pushed message class on consume #214

Merged
merged 9 commits into from
Nov 24, 2024
Merged

Allow to restore original pushed message class on consume #214

merged 9 commits into from
Nov 24, 2024

Conversation

viktorprogger
Copy link
Contributor

@viktorprogger viktorprogger commented Sep 15, 2024 •
edited
Loading

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌

This PR allows you to push your own message class and then get it back after it was consumed.
See new tests for details.

@viktorprogger viktorprogger added the status:code review The pull request needs review. label Sep 15, 2024
@viktorprogger viktorprogger requested review from samdark, s1lver, xepozz and a team September 15, 2024 17:28
@viktorprogger viktorprogger self-assigned this Sep 15, 2024
samdark
samdark requested changes Sep 16, 2024
View reviewed changes
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, docs should be updated to include info about envelopes.

src/Message/EnvelopeTrait.php Show resolved Hide resolved
src/Message/JsonMessageSerializer.php Outdated Show resolved Hide resolved
src/Message/JsonMessageSerializer.php Outdated Show resolved Hide resolved
src/Message/JsonMessageSerializer.php Outdated Show resolved Hide resolved
tests/Unit/Message/JsonMessageSerializerTest.php Outdated Show resolved Hide resolved
@viktorprogger
Copy link
Contributor Author

@samdark issue for the docs improvement: #215

@viktorprogger viktorprogger mentioned this pull request Nov 17, 2024
Open
@viktorprogger viktorprogger merged commit af0fb00 into master Nov 24, 2024
19 of 25 checks passed
@viktorprogger viktorprogger deleted the restore-message-class branch November 24, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@s1lver s1lver Awaiting requested review from s1lver

@xepozz xepozz Awaiting requested review from xepozz

Assignees

@viktorprogger viktorprogger

Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viktorprogger @samdark @StyleCIBot