Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor populateInverseRelation() to separate ArrayAccess implementation #354

Merged
merged 5 commits into from
May 28, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented May 27, 2024

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC?
Fixed issues #308

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 86.72%. Comparing base (d8fa21d) to head (238b1c4).

Files Patch % Lines
src/ActiveRelationTrait.php 72.72% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #354      +/-   ##
============================================
- Coverage     87.05%   86.72%   -0.33%     
- Complexity      599      600       +1     
============================================
  Files            13       13              
  Lines          1390     1401      +11     
============================================
+ Hits           1210     1215       +5     
- Misses          180      186       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit b52db34 into master May 28, 2024
55 of 57 checks passed
@Tigrov Tigrov deleted the refactor-populateInverseRelation branch May 28, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants