Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor populateRelation() to separate ArrayAccess implementation #351

Merged
merged 1 commit into from
May 27, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented May 27, 2024

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC?
Fixed issues #308

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 87.44%. Comparing base (3beda50) to head (abea1b2).

Files Patch % Lines
src/ActiveRelationTrait.php 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #351   +/-   ##
=========================================
  Coverage     87.43%   87.44%           
  Complexity      601      601           
=========================================
  Files            13       13           
  Lines          1385     1386    +1     
=========================================
+ Hits           1211     1212    +1     
  Misses          174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit 2c1010d into master May 27, 2024
57 of 59 checks passed
@Tigrov Tigrov deleted the refactor-populateRelation branch May 27, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant