Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor populateRecord() to split ArrayAccess implementation #350

Merged
merged 1 commit into from
May 27, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented May 25, 2024

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC?
Fixed issues #308

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 87.43%. Comparing base (804ca3f) to head (98295c7).

Files Patch % Lines
src/ArArrayHelper.php 62.50% 3 Missing ⚠️
src/AbstractActiveRecord.php 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #350      +/-   ##
============================================
- Coverage     88.13%   87.43%   -0.71%     
- Complexity      597      601       +4     
============================================
  Files            13       13              
  Lines          1374     1385      +11     
============================================
  Hits           1211     1211              
- Misses          163      174      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit 3beda50 into master May 27, 2024
55 of 59 checks passed
@Tigrov Tigrov deleted the refactor-populateRecord branch May 27, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant