Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor indexBuckets() remove ArrayAccess implementation #349

Merged
merged 2 commits into from
May 25, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented May 25, 2024

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC?
Fixed issues #308

Copy link

codecov bot commented May 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.13%. Comparing base (ad73d8f) to head (1bbbeed).

Current head 1bbbeed differs from pull request most recent head d839389

Please upload reports for the commit d839389 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #349      +/-   ##
============================================
- Coverage     88.17%   88.13%   -0.04%     
+ Complexity      599      597       -2     
============================================
  Files            13       13              
  Lines          1378     1374       -4     
============================================
- Hits           1215     1211       -4     
  Misses          163      163              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit 804ca3f into master May 25, 2024
2 of 3 checks passed
@Tigrov Tigrov deleted the refactor-indexBuckets branch May 25, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant