Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - rename getObjectVars() to getAttributesInternal() #347

Merged
merged 1 commit into from
May 25, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented May 25, 2024

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC?
Fixed issues #308

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.10%. Comparing base (1564264) to head (cb518db).

Files Patch % Lines
src/AbstractActiveRecord.php 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #347      +/-   ##
============================================
+ Coverage     87.16%   88.10%   +0.93%     
+ Complexity      607      599       -8     
============================================
  Files            13       13              
  Lines          1395     1379      -16     
============================================
- Hits           1216     1215       -1     
+ Misses          179      164      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit 4d6bcaf into master May 25, 2024
57 of 59 checks passed
@Tigrov Tigrov deleted the refactor-getAttributesInternal branch May 25, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant