Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MagicPropertiesTrait #337

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented May 22, 2024

Q A
Is bugfix? ✔️
New feature?
Breaks BC? ✔️/❌
Fixed issues #308

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 87.41%. Comparing base (352e04d) to head (22677c7).

Files Patch % Lines
src/Trait/MagicPropertiesTrait.php 83.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #337      +/-   ##
============================================
- Coverage     87.61%   87.41%   -0.21%     
- Complexity      599      603       +4     
============================================
  Files            13       13              
  Lines          1381     1390       +9     
============================================
+ Hits           1210     1215       +5     
- Misses          171      175       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit c5a5081 into master May 22, 2024
54 of 57 checks passed
@Tigrov Tigrov deleted the refactor-MagicPropertiesTrait branch May 22, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant