Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ArrayAccessTrait #333

Merged
merged 5 commits into from
May 21, 2024
Merged

Refactor ArrayAccessTrait #333

merged 5 commits into from
May 21, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented May 21, 2024

Refactor ArrayAccessTrait for compatibility without magical implementation.

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC?
Fixed issues #308

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 87.44%. Comparing base (5c28c20) to head (946db16).

Files Patch % Lines
src/Trait/ArrayAccessTrait.php 42.85% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #333      +/-   ##
============================================
- Coverage     88.20%   87.44%   -0.76%     
- Complexity      586      596      +10     
============================================
  Files            12       12              
  Lines          1339     1362      +23     
============================================
+ Hits           1181     1191      +10     
- Misses          158      171      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit c3477c4 into master May 21, 2024
55 of 57 checks passed
@Tigrov Tigrov deleted the refactor-ArrayAccessTrait branch May 21, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants