Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #324

Merged
merged 4 commits into from
May 20, 2024
Merged

Refactoring #324

merged 4 commits into from
May 20, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented May 20, 2024

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC?
Fixed issues #308

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.77%. Comparing base (107cd30) to head (948d1ca).

Current head 948d1ca differs from pull request most recent head 81a6632

Please upload reports for the commit 81a6632 to get more accurate results.

Files Patch % Lines
src/ActiveQuery.php 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #324      +/-   ##
============================================
+ Coverage     87.72%   87.77%   +0.04%     
  Complexity      581      581              
============================================
  Files            12       12              
  Lines          1328     1333       +5     
============================================
+ Hits           1165     1170       +5     
  Misses          163      163              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit b4e4db5 into master May 20, 2024
3 checks passed
@Tigrov Tigrov deleted the refactoring branch May 20, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants