Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create MagicPropertiesTrait #318

Merged
merged 6 commits into from
May 20, 2024
Merged

Create MagicPropertiesTrait #318

merged 6 commits into from
May 20, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented May 19, 2024

Q A
Is bugfix?
New feature? ✔️/❌
Breaks BC? ✔️
Fixed issues #308

Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 86.98%. Comparing base (13c782f) to head (0d2b160).

Files Patch % Lines
src/BaseActiveRecord.php 48.14% 14 Missing ⚠️
src/Trait/MagicPropertiesTrait.php 95.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #318      +/-   ##
============================================
- Coverage     88.25%   86.98%   -1.27%     
- Complexity      566      576      +10     
============================================
  Files            11       11              
  Lines          1294     1314      +20     
============================================
+ Hits           1142     1143       +1     
- Misses          152      171      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit 0c89029 into master May 20, 2024
55 of 57 checks passed
@Tigrov Tigrov deleted the create-MagicPropertiesTrait branch May 20, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants